4 May
2023
4 May
'23
3:30 p.m.
On Thu, May 04, 2023 at 03:08:14PM +0200, Jaroslav Kysela wrote:
On 04. 05. 23 15:00, Oswald Buddenhagen wrote:
So we logically revert some bits from commit 9f656705c5faa ("ALSA: pcm: rewrite snd_pcm_playback_silence()"), but we retain the bug fixes and try to make the code paths congruent.
It would be better to revert the broken patch and make changes on top of the original code. This is really difficult to review.
the diff to the old code is just as big, which is a somewhat inevitable effect of it being the middle way between both.
the best way to review it is with `git show -b`.
regards