7 Sep
2009
7 Sep
'09
1:50 p.m.
On Mon, Sep 07, 2009 at 12:40:02PM +0200, Takashi Iwai wrote:
Where we are at it: Mark, could you fix the initialization of io_types[] in C99 style? For this case, C99 style initialization is suited better since some fields are optional now.
Meh, I guess.
Also, I find the current unbalanced hw_read/hw_write definitions uneasy. hw_read takes the codec instance while hw_write takes i2c instance (and hw_read_t is dead). It'd be nice if you can fix these as well.
I don't think it's worth the pain until more of the drivers are using the shared cache functions - making changes like that more straightforward is one of the goals of doing this refactoring.