On Sat, 21 Nov 2020, James Bottomley James.Bottomley@HansenPartnership.com wrote:
On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote:
A difficult part of automating commits is composing the subsystem preamble in the commit log. For the ongoing effort of a fixer producing one or two fixes a release the use of 'treewide:' does not seem appropriate.
It would be better if the normal prefix was used. Unfortunately normal is not consistent across the tree.
D: Commit subsystem prefix
ex/ for FPGA DFL DRIVERS
D: fpga: dfl:
I've got to bet this is going to cause more issues than it solves.
Agreed.
SCSI uses scsi: <driver>: for drivers but not every driver has a MAINTAINERS entry. We use either scsi: or scsi: core: for mid layer things, but we're not consistent. Block uses blk-<something>: for all of it's stuff but almost no <somtehing>s have a MAINTAINERS entry. So the next thing you're going to cause is an explosion of suggested MAINTAINERs entries.
On the one hand, adoption of new MAINTAINERS entries has been really slow. Look at B, C, or P, for instance. On the other hand, if this were to get adopted, you'll potentially get conflicting prefixes for patches touching multiple files. Then what?
I'm guessing a script looking at git log could come up with better suggestions for prefixes via popularity contest than manually maintained MAINTAINERS entries. It might not always get it right, but then human outsiders aren't going to always get it right either.
Now you'll only need Someone(tm) to write the script. ;)
Something quick like this:
git log --since={1year} --pretty=format:%s -- <FILES> |\ grep -v "^(Merge|Revert)" |\ sed 's/:[^:]*$//' |\ sort | uniq -c | sort -rn | head -5
already gives me results that really aren't worse than some of the prefixes invented by drive-by contributors.
Has anyone actually complained about treewide:?
As Joe said, I'd feel silly applying patches to drivers with that prefix. If it gets applied by someone else higher up, literally treewide, then no complaints.
BR, Jani.