Re: [alsa-devel] [PATCH 03/17] firewire-lib: Add 'direction' member to 'amdtp_stream' structure

(Nov 26 2013 00:27), Clemens Ladisch wrote:

...

+enum amdtp_stream_direction {

• AMDTP_RECEIVE_STREAM = 0,
• AMDTP_TRANSMIT_STREAM

+};

We have two FireWire nodes, the PC and the audio device. Both streams are transmitted by a node and received by a node, so these names does not actually specify a direction.

The DMA API uses names like DMA_FROM/TO_DEVICE for this. Alternatively, you could use something like PLAYBACK/CAPTURE.

OK. This is related to patch 04. How is to use 'in/out' like this?

enum amdtp_stream_direction { AMDTP_IN_STREAM, AMDTP_OUT_STREAM };

#define IN_PACKET_HEADER_SIZE 4 #define OUT_PACKET_HEADER_SIZE 0

Here I choice 'in/out' because of characters.

Thank you.

Takashi Sakamoto o-takashi@sakamocchi.jp