Re: [alsa-devel] [PATCH] ASoC: imx-sgtl5000: do not use devres on a foreign device

25 Sep 2013


      Hi Shawn,
Am Mittwoch, den 25.09.2013, 20:14 +0800 schrieb Shawn Guo:
...
On Wed, Sep 25, 2013 at 12:16:08PM +0200, Philipp Zabel wrote:
...
Calling devm_clk_get with any device pointer other than our own confuses
devres. Use clk_get instead. This avoids hitting the following warning in
the imx-sgtl5000 error path:
[...]
...
This is a known issue [1].  Thanks for fixing it.
...
Signed-off-by: Philipp Zabel p.zabel@pengutronix.de
Acked-by: Shawn Guo shawn.guo@linaro.org
Shawn
thanks, I just noticed that 01984a47e21a7d36cea0d6c0933c8173391721fc
"ASoC: imx-sgtl5000: Use devm_snd_soc_register_card" in the meantime
removed imx_sgtl5000_remove. I'll add it back again and resend the patch
rebased on top of asoc/for-next.
regards
Philipp