On Tue, Apr 23, 2024 at 7:54 AM Mark Brown broonie@kernel.org wrote:
On Mon, Apr 22, 2024 at 09:28:45PM +0300, Andy Shevchenko wrote:
I can't find this in the mailing list.
That was like v9 or something, as you later noticed it's been on the list over a very extended period with many revisions - there has been a more than adequate opportunity for review here (Pierre did a bunch for example).
Right, I simply looked at the wrong place, sorry.
Moreover, it has an obstacle to be applied, i.e. as per https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5 the gpio.h must not be included in a new code and brief looking into that driver shows that legacy APIs are being used without _any_ good reason.
This has to be fixed (by the author).
Or someone else, for example you could do it if you were so moved.
Sure.
You haven't even CCed Shenghao here... please at least send a mail to him explaining the issue.
I Cc'ed in the last of the three I have sent.