Re: [alsa-devel] [PATCHv2] ASoC: Fix wrong data type access in a few codec drivers

Jarkko Nikula wrote at Friday, May 13, 2011 10:17 AM:

Commit fafd217 ("ASoC: Store a list of widgets in a DAPM mux/mixer kcontrol") changed the control private data type that is passed to snd_soc_cnew when creating dapm mixer and mux controls. Commit did not update a few codec drivers that are using their own put callbacks and thus are accessing a wrong data type.

Signed-off-by: Jarkko Nikula jhnikula@gmail.com Tested-by: Stephen Warren swarren@nvidia.com

---

v2:

• wm8994 and wm8995 needs to be changed too. Thanks to Stephen Warren swarren@nvidia.com for noticing.
• "Otherwise, on Tegra+WM8903, I repro'd the bug, and tested the fix, so: Tested-by: Stephen Warren swarren@nvidia.com"

This version looks good to me. I guess that means:

Acked-by: Stephen Warren swarren@nvidia.com

... although I figure my Tested-by is probably enough.

Thanks for fixing my bugs!