Re: [alsa-devel] [PATCH] Convert bitfields in ASOC into full int width

On Wed, Jul 23, 2008 at 11:49:50AM -0400, Jon Smirl wrote:

Mask is usually the same as mask, but hasn't this been written to allow a max smaller than the max? If so these two areas look wrong.

Yes, that's the idea.

if (power) {
	int i;
	/* power up has happended, increase volume to last level */
	if (invert) {

// shouldn't this be // for (i = max; i > widget->saved_value; i--) for (i = mask; i > widget->saved_value; i--) // and this mask is right

I think so.

And this one should have used mask instead of max:

Looks like it, yes.