At Tue, 13 Aug 2013 12:32:12 +0200, Knut Petersen wrote:
On 13.08.2013 09:19, Takashi Iwai wrote:
Well, looking at rme96.c, the rme96 driver code can be cleaned up and lots of redundant checks can be reduced, then the sync-support patch will be the half size. For example, it's almost useless to check RME96_ISPLAYING() in trigger, or doing in close or prepare callback. (It's still valid to do it in snd_rme96_create(), though, since the register values are unknown at the first initialization state, though.)
But it's no serious problem, and we can live with the current code. So the only problem is the coding-style issues in your patch.
Ok, I admit that I never used scripts/checkpatch.pl ;-) Alsa, feeding the current rme96.c code to scripts/checkpatch.pl gives 235 errors and 205 warnings:
You just need to fix the coding issue of your patch, not the whole existing driver code.
Takashi