19 Sep
2012
19 Sep
'12
3:13 a.m.
On Wed, Sep 19, 2012 at 02:58:29AM +0000, Tabi Timur-B04825 wrote:
Mark Brown wrote:
...please don't introduce unrelated changes, especially ones you don't mention in the changelog.
Well, the introduction of variable 'format' is for the default case in the switch statement:
I saw that, that's why I didn't write "random stylistic changes" (as I had originally, I nearly discarded the patch before I read that far).
default:dev_err(codec->dev, "unsupported format %i\n", format);return -EINVAL;
I would not call this change "unrelated".
It's not adding a new format, it's changing the error reporting. That's a sensible thing to do and could have been done as part of the same patch but it should've been mentioned in the changelog.