On 10.03.2022 16:49, Dan Carpenter wrote:
Hello Codrin Ciubotariu,
Hi Dan,
The patch 50291652af52: "ASoC: atmel: mchp-pdmc: add PDMC driver" from Mar 7, 2022, leads to the following Smatch static checker warning:
sound/soc/atmel/mchp-pdmc.c:186 mchp_pdmc_af_put() warn: this array is probably non-NULL. 'uvalue->value.integer.value'sound/soc/atmel/mchp-pdmc.c 181 static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol, 182 struct snd_ctl_elem_value *uvalue) 183 { 184 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 185 struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component); --> 186 bool af = uvalue->value.integer.value ? true : false; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ value is an array, not a pointer. It's always going to be non-NULL.
Indeed. There is already a patch that addresses this [1]. Thank you for your report!
Best regards, Codrin