Re: [PATCH 3/8] iio: accel: bmc150: Move check for second ACPI device into a separate function

On Fri, May 21, 2021 at 11:23 PM Hans de Goede hdegoede@redhat.com wrote:

Move the check for a second ACPI device for BOSC0200 ACPI fwnodes into a new bmc150_acpi_dual_accel_probe() helper function.

This is a preparation patch for adding support for a new "DUAL250E" ACPI Hardware-ID (HID) used on some devices.

...

+#ifdef CONFIG_ACPI +static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {

•   {"BOSC0200"},
  

•   { },
  

I guess it is a good chance to drop a comma.

+};

...

•   if (!IS_ERR(second_dev))
  

•           bmc150_set_second_device(client, second_dev);
  

I would comment on the pattern here, but I have noticed that this code is changed in the further patches anyway.