Re: [alsa-devel] [PATCH 3/3] ASoC: Blackfin I2S: Setting the TFS pin selector for SPORT 0 based on whether the selected port id F or G.

At Tue, 21 Oct 2008 11:36:13 +0800, Bryan Wu wrote:

From: Cliff Cai cliff.cai@analog.com

Also include some small coding style cleanup.

Try checkpatch.pl to make sure that you really cleaned up, not added new warnings :)

@@ -98,23 +109,21 @@ static int bf5xx_i2s_set_dai_fmt(struct snd_soc_dai *cpu_dai, ret = -EINVAL; break; default:

• printk(KERN_ERR "Unknown SND_SOC_DAIFMT_FORMAT type\n");
  

Put some prefix for error messages. Otherwise you don't know who tells it.

ret = -EINVAL;
break;

}

switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {

• case SND_SOC_DAIFMT_CBS_CFS:

• ret = -EINVAL;
  

• break;
  

• case SND_SOC_DAIFMT_CBM_CFS:

• ret = -EINVAL;
  

• break;
  

  case SND_SOC_DAIFMT_CBM_CFM: break;

• case SND_SOC_DAIFMT_CBS_CFS:
• case SND_SOC_DAIFMT_CBM_CFS: case SND_SOC_DAIFMT_CBS_CFM: ret = -EINVAL; break; default:

• printk(KERN_ERR "Unknown SND_SOC_DAIFMT_MASTER type\n");
  

Ditto.

thanks,

Takashi