Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset

On Sat, Nov 11, 2023 at 8:18 PM Alexander Sverdlin alexander.sverdlin@gmail.com wrote:

On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:

...

...

...

•   mdelay(1000);
  

Atomic?! Such a huge delay must be explained, esp. why it's atomic.

atomic or not, SoC is supposed to reset itself here. However there is an errata [1] and the SoC can lockup instead.

Good, and what I'm saying is that this piece of code must have a comment explaining this.

So even pr_emerg() makes sense to me.

This is irrelevant to the comment.

...

...

•   pr_emerg("Unable to restart system\n");
  

•   return NOTIFY_DONE;
  

[1] http://web.archive.org/web/20161130230727/http://www.cirrus.com/en/pubs/appN...