On 2020-01-27 22:17, Pierre-Louis Bossart wrote:
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 827b0ec92522..0fca86164472 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -171,6 +171,15 @@ config SND_SOC_SOF_DEBUG_RETAIN_DSP_CONTEXT Say Y if you want to retain DSP context for FW exceptions. If unsure, select "N". +config SND_SOC_SOF_DEBUG_PROBES + bool "SOF enable data probing" + select SND_SOC_COMPRESS + help + This option enables the data probing feature that can be used to + gather data directly from specific points of the audio pipeline. + Say Y if you want to enable probes. + If unsure, select "N".
endif ## SND_SOC_SOF_DEBUG endif ## SND_SOC_SOF_DEVELOPER_SUPPORT
we need to agree with firmware folks on a) making sure the probes are enabled on all SKL+ firmware b) we have a means to detect if probes are supported by the firmware.
I think the probes should be enabled in all distributions, even when using firmware signed with a production key, it doesn't impact anything until the root user explicitly configures probe points.
Since we explicitly advise distributions not to include developer options, we probably need to move this Kconfig outside. of these two 'if' blocks.
Indeed, now it's FW folks time to act.
Moved outside of _DEVELOPER_SUPPORT block as requested. Left the _DEBUG_ tag to notify user about probe being a debug feature. Once the _DEVELOPER_SUPPORT / _DEBUG features are sorted out, this will be relocated under _DEBUG block again.
As stated in patch 07, 'extractor_stream_tag' declaration has been relocated into this very patch as it should be from the get-go.
Thanks, Czarek