Re: [alsa-devel] [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support

On Mon, 2009-08-17 at 12:27 +0100, Mark Brown wrote:

• /* If there are no DAPM widgets then try to figure out power from the

• * event type.
  

• */
  

• if (list_empty(&codec->dapm_widgets)) {

• switch (event) {
  

• case SND_SOC_DAPM_STREAM_START:
  

• case SND_SOC_DAPM_STREAM_RESUME:
  

• 	sys_power = 1;
  

• 	break;
  

• case SND_SOC_DAPM_STREAM_NOP:
  

• 	sys_power == codec->bias_level != SND_SOC_BIAS_STANDBY;
  

Should be "sys_power = codec->bias_level != SND_SOC_BIAS_STANDBY;" ?

• default:
  

• 	break;
  

• }
  

• }
• /* If we're changing to all on or all off then prepare */ if ((sys_power && codec->bias_level == SND_SOC_BIAS_STANDBY) || (!sys_power && codec->bias_level == SND_SOC_BIAS_ON)) {