Hi
On 8/10/19 12:16 PM, Jarkko Nikula wrote:
Hi
On 8/8/19 8:52 AM, Kuninori Morimoto wrote:
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
To find aux_dev, ASoC is using .name, codec_name, codec_of_node. Here, .name is used to fallback in case of no codec.
But, we already have this kind of component finding method by snd_soc_dai_link_component and soc_find_component(). We shouldn't have duplicated implementation to do same things. This patch adds snd_soc_dai_link_component support to finding aux_dev.
Now, no driver is using only .name. All drivers are using codec_name and/or codec_of_node. This means no driver is finding component from .name so far. (Actually almost all drivers are using .name as just "device name", not for finding component...)
This patch
- add snd_soc_dai_link_component support for aux_dev. legacy style will be removed if all drivers are switched to new style.
- try to find component via snd_soc_dai_link_component. Then, it doesn't try to find via .name, because no driver is using it so far.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
include/sound/soc.h | 7 +++++++ sound/soc/soc-core.c | 36 ++++++++++-------------------------- 2 files changed, 17 insertions(+), 26 deletions(-)
...
Bike-shedding: maybe comment here should say legacy style binding etc? I know these lines are removed by patch 13/15 but here yet comment is not valid :-)
I forgot to add
Tested-by: Jarkko Nikula jarkko.nikula@bitmer.com