17 Oct
2014
17 Oct
'14
1:55 p.m.
On Fri, Oct 17, 2014 at 02:09:18PM +0200, Mark Brown wrote:
On Thu, Oct 16, 2014 at 08:00:16PM +0530, Vinod Koul wrote:
- spin_unlock_bh(&ctx->block_lock);
- dev_dbg(ctx->dev,
"Block not found or a response received for a short msg for ipc %d, drv_id %d\n",ipc, drv_id);- return -EINVAL;
Shouldn't this be a dev_err() or something?
Not really.
We get response from FW which cna be short or long. In former there wont be anyone waiting as all blocked ones are large. We cant distiguish between the two thats why we log debug message here. If its real then finally the message will timeout and we would see that as error. Yes this is limiation in IPC. Putting this as err makes log very noisy :(
--
~Vinod