24 Jun
2019
24 Jun
'19
3:15 p.m.
On Mon, 24 Jun 2019 12:53:34 +0200, Mark Brown wrote:
On Sat, Jun 22, 2019 at 10:39:11PM +0200, Takashi Iwai wrote:
Well, I just wonder whether you have ever seen a case where the debugfs creation failed. Or more practically, would it fail silently at all?
If there can be a silent failure, then it's bad to just ignore, yes. We may need either to make it more obvious or return an error.
Currently debugfs doesn't report any errors other than via the return codes (at least in the common creation stuff) so it's up to the callers to do that.
So this should be changed to follow a la sysfs creation error, IMO. At least, the name conflicts etc should be reported more obviously.
thanks,
Takashi