Re: [alsa-devel] [PATCH 02/14] soundwire: Add SoundWire bus type

On Thu, 19 Oct 2017 09:40:06 +0200, Takashi Iwai wrote:

On Thu, 19 Oct 2017 05:03:18 +0200, Vinod Koul wrote:

...

--- /dev/null +++ b/drivers/soundwire/Kconfig @@ -0,0 +1,22 @@ +# +# SoundWire subsystem configuration +#

+menuconfig SOUNDWIRE

• bool "SoundWire support"
• ---help---

•  SoundWire is a 2-Pin interface with data and clock line ratified
  

•  by the MIPI Alliance. SoundWire is used for transporting data
  

•  typically related to audio functions. SoundWire interface is
  

•  optimized to integrate audio devices in mobile or mobile inspired
  

•  systems
  

+if SOUNDWIRE

+comment "SoundWire Devices"

+config SOUNDWIRE_BUS

• tristate
• default SOUNDWIRE

Does it make sense to be tristate? Since CONFIG_SOUNDWIRE is a bool, the above would be also only either Y or N. If it's Y and others select M, it'll be still Y.

I found a later patch selecting SOUNDWIRE_BUS. So just drop this "default" line, and always let others selecting the bus.

Takashi