On 10/15/19 2:07 AM, Daniel Baluta wrote:
On Tue, Oct 15, 2019 at 9:57 AM Kuninori Morimoto kuninori.morimoto.gx@renesas.com wrote:
Hi Daniel
Content-Transfer-Encoding: 8bit
Without <types.h> we will get these error
linux/include/sound/sof/header.h:125:2: error: unknown type name ‘uint32_t’uint32_t size; linux/include/sound/sof/header.h:136:2: error: unknown type name ‘uint32_t’uint32_t size; linux/include/sound/sof/header.h:137:2: error: unknown type name ‘uint32_t’uint32_t cmd; ... linux/include/sound/sof/dai-imx.h:18:2: error: unknown type name ‘uint16_t’uint16_t reserved1; linux/include/sound/sof/dai-imx.h:30:2: error: unknown type name ‘uint16_t’uint16_t tdm_slot_width; linux/include/sound/sof/dai-imx.h:31:2: error: unknown type name ‘uint16_t’uint16_t reserved2;
I think your patch is OK, but you should update the commit message because Stephen Rothwell already fixed dai-imx.h compilation error in linux-next.
I see. Thanks
But hmm... I couldn't find it at linux-next/master today... Not yet merged ?
Yes, this is strange. I've sent an email to Stephen and also added you to Cc.
But, your patch is still valid because Stephen used +#include <linux/types.h> in dai-imx.h and you are now fixing the generic situation by including it in header.h.
Lets see if Stephen can clarify the situation. Perhaps we can drop his patch and only have yours.
this is a file shared with the firmware, we shouldn't have to add linux specific stuff in there.
Also I don't know how you get those errors, we've been using this file for some time, can you clarify how this error happens?
Thanks.
Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel