Re: [PATCH v2] ALSA: hda: handle UAF at probe error

On 4/15/2022 9:27 AM, Takashi Iwai wrote:

On Thu, 14 Apr 2022 20:24:37 +0200, Nirmoy Das wrote:

...

Call snd_card_free_on_error() on probe error instead of calling snd_card_free() which should handle devres call orders.

This won't change any practical behavior, because HD-audio driver doesn't use snd_devm_card_new().

OK, I guess I am looking into some timing dependent issue because with the

patch I didn't see the UAF.

Thanks,

Nirmoy

snd_card_free() still gets called explicitly in the relevant code paths.

...

Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701

So it must be a different cause for this problem...

thanks,

Takashi