On Fri, Mar 30, 2018 at 12:12:48PM +0530, Vinod Koul wrote:
On Thu, Mar 29, 2018 at 08:57:59PM -0500, Pierre-Louis Bossart wrote:
On 3/28/18 4:38 AM, Vinod Koul wrote:
+/**
- sdw_slave_runtime: Runtime Stream parameters for Slave
- @slave: Slave handle
- @direction: Data direction w.r.t Slave
- @ch_count: Channel count of the Slave w.r.t stream
same here, I flagged all this already as needing to be fixed. Something's not right here, looks to me like you send the wrong version of the patches...
Somehow missed this bit will fix
On this one, I think i need more help.
SO is your question on direction right, we are thinking of making it:
enum sdw_data_direction { SDW_DATA_TX, SDW_DATA_RX, }
and then use it is SDW. Is that okay for you or not..
For ch_count, we will update the comment.
+struct sdw_master_runtime {
- struct sdw_bus *bus;
- struct sdw_stream_runtime *stream;
- unsigned int ch_count;
- struct list_head slave_rt_list;
- struct list_head bus_node;
+};
no direction?
Yes no direction here. Why would sdw_master_runtime need direction.
If you look closely we do have direction but in data ports.
One can argue we can move direction up here and remove from data ports, that seems logical, is that something you would like to see?
+enum sdw_data_direction {
- SDW_DATA_DIR_IN = 0,
- SDW_DATA_DIR_OUT = 1,
+};
WTH? Didn't we agree that we would use SoundWire concepts instead of redefining new concepts.
So we will make this TX/RX as discussed.
-- ~Vinod