Sorry to be late.
On Dec 2 2014 15:41, Takashi Iwai wrote:
You see now that you're breaking user's setup, don't you? This is another reason why you shouldn't change the short name string.
In this case, it depends on the estimated number of actual users for this device.
No. The number doesn't matter unless it's proved to be really no regression.
At least, snd-firewire-speakers cannot handle this device correctly, while there're no bug reports, for 4 years. I think this is an evidence of few users.
Did you get reports that the name hw:Speaker is bad, too? If not, why do you insist to "fix" this at all? It's just because you feel so -- which is no objective measurement, either.
Not. Just depending on my feeling.
...although havind said so, it's not my favorite to spend more time to such a small things, instead of more important things. I'll keep the naming rule what it was in next patchset.
There is no more important things than fixing a regression.
Just fix it for the next patchset, or patches won't be accepted. That's so simple.
I'm giving a strong word here because you might miss the point: in such a rewrite, the primary item you have to care is to avoid regressions. Supporting other devices, the cleanness of the code, or even the correctness of the code, is hence in the second place.
I'm sure.
This weekend, I'll post the next patchset. I hope it's the last one for OXFW 970/971.
Regards
Takashi Sakamoto o-takashi@sakamocchi.jp