On Thu, Feb 25, 2010 at 10:06 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Thu, Feb 25, 2010 at 08:00:13PM +0900, jassi brar wrote:
On Thu, Feb 25, 2010 at 7:03 PM, Mark Brown
I thought I'd been fairly clear last time that the drivers need to have an option to do stuff on startup(). As I said then a separate callback which is called only on the transitions into and out of active would be fine.
This is simply the patch, that you asked me to dig out from samsung-git and post to the list, adapted to for-2.6.35
I asked you to pull out the bits that maintain active.
hmm... i misread ur reply. Just submitted refreshed patch for just that.
I could drop startup,shutdown,mute-on/off as well, but no codec driver would work with that as such. If that's ok, i'll resend the patch.
Honestly I didn't read the rest of the patch after I saw the change to remove the startup() callback. Clearly fiddling around with the active count isn't going to make every possible system work, and it may not be any use at all, but so long as it doesn't interfere with other users it's not really a problem.
Also, I think we should look into if we can do without snd_soc_codec.active when we have snd_soc_dai.playback/capture.active counters.