On Thu, Sep 19, 2019 at 08:11:41PM +0800, Shengjiu Wang wrote:
When set the runtime hardware parameters, we may need to query the capability of DMA to complete the parameters.
This patch is to Extract this operation from dmaengine_pcm_set_runtime_hwparams function to a separate function snd_dmaengine_pcm_refine_runtime_hwparams, that other components which need this feature can call this function.
Signed-off-by: Shengjiu Wang shengjiu.wang@nxp.com
@@ -145,58 +140,15 @@ static int dmaengine_pcm_set_runtime_hwparams(struct snd_pcm_substream *substrea
ret = snd_dmaengine_pcm_refine_runtime_hwparams(substream,
dma_data,&hw,chan);if (ret)
return ret;return snd_soc_set_runtime_hwparams(substream, &hw);
}
Just a nit, why add a line here? :)
The rest looks good to me, not sure whether the name "refine" would be the best one though, would like to wait for opinions from others.
Thanks