30 Jul
2018
30 Jul
'18
10:49 a.m.
On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote:
From: Edward Cragg edward.cragg@codethink.co.uk
Add a callback to configure TDM settings for the Tegra30 I2S ASoC 'platform' driver.
Signed-off-by: Ben Dooks ben.dooks@codethink.co.uk Signed-off-by: Edward Cragg edward.cragg@codethink.co.uk
This says it was britten by Edward but there's a signoff from Ben before his?
- dev_dbg(dai->dev, "%s: setting TDM: tx_mask: 0x%08x rx_mask: 0x%08x"
"slots: 0x%08x width: %d\n",__func__, tx_mask, rx_mask, slots, slot_width);
Please don't split log messages over lines, it makes it harder to grep for them. Just use a long line.
I'm also not seeing any validation of the parameters?