Re: [alsa-devel] [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls

Hello!

According to changes in API, fix is correct. Acked-by: Alexander Sverdlin subaparts@yandex.ru

On Sat, 2011-11-19 at 14:41 +0800, Axel Lin wrote:

Signed-off-by: Axel Lin axel.lin@gmail.com

sound/soc/codecs/cs4271.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 23d1bd5..69fde15 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c @@ -434,7 +434,8 @@ static int cs4271_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg) { int ret; /* Set power-down bit */

• ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, CS4271_MODE2_PDN);

• ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN,

• 		  CS4271_MODE2_PDN);
  

  if (ret < 0) return ret; return 0;

@@ -501,8 +502,9 @@ static int cs4271_probe(struct snd_soc_codec *codec) return ret; }

• ret = snd_soc_update_bits(codec, CS4271_MODE2, 0,

• CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
  

• ret = snd_soc_update_bits(codec, CS4271_MODE2,

• 		  CS4271_MODE2_PDN | CS4271_MODE2_CPEN,
  

• 		  CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
  

  if (ret < 0) return ret; ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0);