В Tue, 19 Nov 2013 23:23:41 +0100 Clemens Ladisch clemens@ladisch.de пишет:
Many thanks for doing all this work! However, there are still a few small problems.
Roman Volkov wrote:
This patch does some preparation of existing Oxygen driver.
This patch should be separated into four logical changes.
Okay, will split this and send again, considering all your comments.
+++ linux-3.12-my/sound/pci/oxygen/oxygen_io.c 2013-11-19 00:56:12.000000000 +0400
- wait_event_timeout(chip->ac97_waitqueue,
({ status |= oxygen_read8(chip,
OXYGEN_AC97_INTERRUPT_STATUS);
- wait_event_timeout(chip->ac97_waitqueue, ({ status |=
oxygen_read8(chip,
OXYGEN_AC97_INTERRUPT_STATUS); status & mask; }),
Why this change?
Just checkpatch.pl popped me a warning (80 columns exceeded), and I occasionally changed this. Will revert this as this code is already in the kernel.
+int oxygen_wait_spi(struct oxygen *chip) ...
udelay(4);
udelay(1);
Please don't reduce this delay; the CMI8788 has a bug that can crash the machine if this register is polled too often.
+EXPORT_SYMBOL(oxygen_wait_spi);
Why this export?
However yes, when I moved wait call to the end of oxygen_write_spi(), additional waiting is not necessary. Will be the static function.
+++ linux-3.12-my/sound/pci/oxygen/oxygen_mixer.c 2013-11-18 14:03:54.000000000 +0400
+EXPORT_SYMBOL(oxygen_update_dac_routing);
This should be integrated into the patch that adds the actual call.
Regards, Clemens
Kind regards, Roman Volkov v1ron@mail.ru