Re: [alsa-devel] [PATCH v3 05/15] ASoC: phycore-ac97: Add DT support

On Tue, Apr 16, 2013 at 12:59:43PM +0100, Mark Brown wrote:

On Sun, Apr 14, 2013 at 01:42:49PM +0200, Markus Pargmann wrote:

...

• /*

• * This driver doesn't need to know which actual hardware is used.
  

• * The audmux driver has knowledge about it's type, and returns
  

• * an error if executed on the wrong type of hardware.
  

• */
  

• ret = phycore_ac97_pca100_audmux();
• if (!ret)

• return 0;
  

• ret = phycore_ac97_pcm043_audmux();

The DT really ought to be able to give enough information to figure out the audmux configuration. If we can't do that it rather defeats the point of moving to DT...

Yes you are right, I added a phandle "phytec,audmux" to check which audmux setup function we have to use.

Regards,

Markus