On Wed, 17 Apr 2019 05:15:54 +0200, Kailang wrote:
Hi Takashi,
Our AE told me, that EAPD turn on timing which need to set pin out first. It's the safe application. It could avoid pop noise via speaker.
So, could I do the modify as below patch.
OK, that makes sense. alc_auto_init_amp() should be only for EAPD or other amp setups, so from the verb consistency POV, there should be no difference by shuffling the call order, but the timing matters for click noise.
thanks,
Takashi
BR, Kailang
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 810479766090..efcd21b8e0d7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -804,9 +804,8 @@ static int alc_init(struct hda_codec *codec) spec->init_hook(codec);
alc_fix_pll(codec);
- alc_auto_init_amp(codec, spec->init_amp);
- snd_hda_gen_init(codec);
alc_auto_init_amp(codec, spec->init_amp);
snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_INIT);