On Friday 19 December 2014, 21:47:24 wrote Alexandre Belloni:
On 19/12/2014 at 21:42:54 +0100, Alexandre Belloni wrote :
Hi,
On 10/12/2014 at 20:59:36 +0100, Alexander Stein wrote :
+#ifdef CONFIG_OF +static const struct of_device_id atmel_ac97c_dt_ids[] = {
- { .compatible = "atmel,atmel_ac97c", },
I would use atmel,at91sam9263-ac97c, we never now, maybe they will have another ac97 IP at some point in time ;)
This applies for the other patches, else I'm fine with the series.
Maybe you could add CONFIG_SND_ATMEL_AC97C=y in at91_dt_defconfig as all the other defconfigs have disappeared.
BTW: Shouldn't this be rather CONFIG_SND_ATMEL_AC97C=m since it is only applicable on a single microcontroller (AT91SAM9263). There is no need to compile this driver into the kernel on all at91 variants.
Best regards, Alexander