Re: [PATCH] ASoC: dt-bindings: nau8810: Convert to dtschema

16 May 2023

      On 16/05/2023 07:44, David Lin wrote:
...
Convert the NAU8810 audio CODEC bindings to DT schema.
Signed-off-by: David Lin CTLIN0@nuvoton.com
Thank you for your patch. There is something to discuss/improve.
...
+unevaluatedProperties: false

+examples:

|

i2c {
   #address-cells = <1>;

   #size-cells = <0>;

   codec@1a {

       #sound-dai-cells = <0>;

Please put sound-dai-cells at the end. In DTS convention is to have
compatible first, reg second.
With this:
Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
...

       compatible = "nuvoton,nau8810";

       reg = <0x1a>;

   };

};

Best regards,
Krzysztof