On 1/26/21 6:58 PM, Uwe Kleine-König wrote:
All amba drivers return 0 in their remove callback. Together with the driver core ignoring the return value anyhow, it doesn't make sense to return a value here.
Change the remove prototype to return void, which makes it explicit that returning an error value doesn't work as expected. This simplifies changing the core remove callback to return void, too.
Reviewed-by: Ulf Hansson ulf.hansson@linaro.org Reviewed-by: Arnd Bergmann arnd@arndb.de Acked-by: Alexandre Belloni alexandre.belloni@bootlin.com Acked-by: Dmitry Torokhov dmitry.torokhov@gmail.com Acked-by: Krzysztof Kozlowski krzk@kernel.org # for drivers/memory Acked-by: Mark Brown broonie@kernel.org Acked-by: Dmitry Torokhov dmitry.torokhov@gmail.com Acked-by: Linus Walleij linus.walleij@linaro.org Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
For drivers/memory/pl172.c:
Acked-by: Vladimir Zapolskiy vz@mleia.com
-- Best wishes, Vladimir