19 Mar
2014
19 Mar
'14
12:10 p.m.
On Tue, Mar 18, 2014 at 09:02:07AM +0100, Lars-Peter Clausen wrote:
soc-core.c is getting quite crowded. Move all IO related functions that are still in soc-core.c to soc-io.c
No, we're trying to make soc-io smaller! Besides, if this stuff is getting cleaned up then:
-unsigned int snd_soc_read(struct snd_soc_codec *codec, unsigned int reg) -{
- unsigned int ret;
- ret = codec->read(codec, reg);
- dev_dbg(codec->dev, "read %x => %x\n", reg, ret);
- trace_snd_soc_reg_read(codec, reg, ret);
- return ret;
-} -EXPORT_SYMBOL_GPL(snd_soc_read);
...making small things like this static inlines in a header is probably a better move (we can probably drop the trace - I don't think anything in active development doesn't use regmap and it's a carrot to push people).