On Mon, Mar 05, 2012 at 01:30:42PM +0100, Lars-Peter Clausen wrote:
On 03/02/2012 02:59 PM, Mark Brown wrote:
Please resend the ep93xx conversion along with the tweak to the core so we can get that working.
I was at trade show for the rest of last week, without much time for anything else. I will submit the missing patches in a moment.
No problem, I figured it was something like that and didn't see any reason not to get the changes into 3.4 - it's a substantial win all round and the fixes are pretty minior.
It would also be good to update FSI to use this library as it's also using dmaengine (the patch having been merged just before this one it got missed in the updates I expect).
I've had a look at the FSI dmaengine driver and it is not straight forward to convert. For one it does not use cyclic dma transfers so it is more something for Russel's patch and on the other hand the FSI PCM driver introduces another layer of indirection which is used to be able to switch between PIO and DMA. But as a result the functions the dmaengine PCM framework provides don't really fit anymore.
OK, fair enough.