On Wed, May 01, 2019 at 10:57:25AM -0500, Pierre-Louis Bossart wrote:
No C++ comments in .h files
That's not really the issue here.
Reviewed-by: Takashi Iwai tiwai@suse.de Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
drivers/soundwire/bus.h | 4 ++-- drivers/soundwire/cadence_master.h | 4 ++-- drivers/soundwire/intel.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h index c77de05b8100..2f8436584e7f 100644 --- a/drivers/soundwire/bus.h +++ b/drivers/soundwire/bus.h @@ -1,5 +1,5 @@ -// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -// Copyright(c) 2015-17 Intel Corporation. +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ +/* Copyright(c) 2015-17 Intel Corporation. */
The first line is fine to change, as that was the requirement (although I think it has now been fixed), the second line is just taste, whatever you want, it's not a requirement.
But I really don't care, it's not my code :)
thanks,
greg k-h