18 Sep
2017
18 Sep
'17
1:20 p.m.
Hi Heiko,
Thanks for your reply.
On 09/18/2017 05:30 PM, Heiko Stuebner wrote:
> >-- compatible : "realtek,rt5514". >+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
There's no need for the -spi or -i2c compatibles. This is implied by being a child of those controllers.
heiko mentioned i should add it in the binding in: https://patchwork.kernel.org/patch/9918987/
If you add a new compatible you need to add it to the binding. I think what Rob means is, that both the i2c and spi side can have the_same_ compatible without the -i2c or -spi, as you can check wether they are children of either a spi or i2c controller in the code itself.
ok, got it.
i sent a new patch to check the bus_type instead :)