1 Jul
2014
1 Jul
'14
7:41 p.m.
On Tue, Jul 01, 2014 at 10:11:34PM +0530, Vinod Koul wrote:
On Tue, Jul 01, 2014 at 09:47:59AM +0200, Benoit Cousson wrote:
- for (i = 0; i < rtd->num_codecs; i++) {
struct snd_soc_dai *codec_dai = rtd->codec_dais[i];
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
snd_soc_dai_digital_mute(codec_dai, 0,
cstream->direction);
break;
case SNDRV_PCM_TRIGGER_STOP:
snd_soc_dai_digital_mute(codec_dai, 1,
cstream->direction);
Wouldnt it make sense to fix snd_soc_dai_digital_mute() for multi-codecs. Did you do same thing for pcm?
Yes, the other callers also iterate through all the CODECs. It might be sensible to have a wrapper which does the iteration but I do think it's reasonable for _dai_digital_mute() to just operate on one DAI.