-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Monday, May 04, 2015 7:59 PM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove; Oder Chiou; John Lin; koro.chen@mediatek.com; yang.a.fang@intel.com; zhengxing@rock-chips.com Subject: Re: [PATCH 4/6] ASoC: rt5645: add device tree support
On Mon, May 04, 2015 at 05:21:59AM +0000, Bard Liao wrote:
- Boolean. Indicate if codec IRQ is used or not. It is usually
+used for JD
- and/or headset button detection.
I'm not sure I understand what this is for? I'd expect that the interrupt would be used if specified, though if a GPIO is specified I guess that'd override it.
It is for codec IRQ though it is called en-jd-func. rt5645 IRQ is not for JD only but also other functions (like button detection). Another thing is that a separate CPU pin is used for JD IRQ in some HW design. It means some HW design use their own JD function. That's what hp-det-gpio for.
I'm still not clear here - why is there a need for a separate flag over just specifying the additional GPIO/interrupt to use for this function?
Oh, we can assume codec IRQ is used if codec JD or button detection function is used. I will send a patch to remove dmic_en and en_jd_func in platform data and send the device tree support patch again.
Thanks.
------Please consider the environment before printing this e-mail.