On Tue, 11 Aug 2009 21:44:29 +0200 Janusz Krzysztofik jkrzyszt@tis.icnet.pl wrote:
Enhance period_index accuracy, particularly just before buffer rewind, by making use of DMA interrupt status flags in addition to simply counting up interrupts.
Changes since v2:
- } + } else if (stat == OMAP_DMA_LAST_IRQ) + return;
Is this test needed? This interrupt is set only for playback on omap1510 so this looks null-op.
You're right, I have put it here before limiting the flag request to playback on OMAP1510 only. So it can be omitted...
+ omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ | + OMAP_DMA_LAST_IRQ);
Indent OMAP_DMA_LAST_IRQ with tab(s) and spaces to the same column than OMAP_DMA_FRAME_IRQ. Looks nicer then.
OK, will fix it.
Should the OMAP_DMA_BLOCK_IRQ to be set since it is handled in omap_pcm_dma_irq?
This one is already requested from inside omap_request_dma() and used inside omap1_dma_handle_ch() in addition to passing it to us.
But for less confusion, it'll be better if requested from here too.
I'm fine with this 3rd version. Probably Mark would like to have git format-patch formatted version for avoiding manual commit log editing.
Acked-by: Jarkko Nikula jhnikula@gmail.com