On Tue, 11 Dec 2018 11:09:59 +0100, Andy Shevchenko wrote:
On Tue, Dec 11, 2018 at 8:02 AM Ayman Bagabas ayman.bagabas@gmail.com wrote:
Some of Huawei laptops come with a LED in the micmute key. This patch enables the use of micmute LED for these devices:
- Matebook X (19e5:3200), (19e5:3201)
- Matebook X Pro (19e5:3204)
Reviewed-by: Takashi Iwai tiwai@suse.de Signed-off-by: Ayman Bagabas ayman.bagabas@gmail.com
sound/pci/hda/patch_realtek.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 1326f32f4574..9766fd249bdf 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5776,7 +5776,9 @@ static const struct hda_fixup alc269_fixups[] = { {0x1e, 0x411111f0}, {0x21, 0x04211020}, { }
}
},This is not related change, but we may fix it when applying.
.chained = true,.chain_id = ALC255_FIXUP_MIC_MUTE_LED
The comma is needed only because you add more fields. So this isn't wrong, per se.
OTOH, you can avoid this extra change if you already had a comma in the first patch, yeah.
thanks,
Takashi