On 8/28/20 2:45 AM, Vinod Koul wrote:
On 28-08-20, 01:47, Liao, Bard wrote:
snd_pcm_substream *substream,
goto err;}
- ret = sdw_prepare_stream(dma->stream);
- /*
* All cpu dais belong to a stream. To ensure sdw_prepare_stream* is called once per stream, we should call it only when* dai = first_cpu_dai.*/- if (first_cpu_dai == dai)
ret = sdw_prepare_stream(dma->stream);Hmmm why not use the one place which is unique in the card to call this, hint machine dais are only called once.
Yes, we can call it in machine driver. But, shouldn't it belong to platform level? The point is that if we move the stuff to machine driver, it will force people to implement these stuff on their own Intel machine driver.
nothing stops anyone from doing that right! machine driver is another component so it can be moved there as well
What Bard is saying is that there is nothing board-specific here. This is platform-driver code that is independent of the actual machine configuration.
Machine drivers can be board-specific, so we would have to add the code for prepare/deprepare/trigger to every machine driver.
Today it's true that we worked to have a single machine driver for all SoundWire-based devices, so the change is a 1:1 move, but we can't guarantee that this would be the case moving forward. In fact, we *know* we will need a different machine driver when we parse platform firmware to create the card for SDCA support. So in the end there would be duplication of code.
See the code we worked on at https://github.com/thesofproject/linux/commit/7322e1d25ce2ec9bb78c6e861919f6...
it'd really a bit silly to have this generic code in the machine driver.
it would be fine to call a set of helpers called from the machine driver dailink, but where would we put these helpers? on the ASoC or SoundWire sides?