I'm very sorry that I misunderstood my last comment, correct it here. Thank you again for you hard review.
On Mon, Oct 16, 2023 at 16:10:17 +0800, wangweidong.a@awinic.com wrote
On Fri, Oct 13, 2023 at 03:10:56 PM +0100, broonie@kernel.org wrote:
On Fri, Oct 13, 2023 at 06:42:20PM +0800, wangweidong.a@awinic.com wrote:
This looks good - some *very* minor comments below.
+static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
unsigned char *data, unsigned int len, unsigned short base)+{
- int i, ret;
+#ifdef AW88399_DSP_I2C_WRITES
- u32 tmp_len;
This looks like debug code which can hopefully be removed in favour of the regmap implementation?
Thank you very much, but this is not a debugging statement, This is designed to be compatible with different platforms that may not support continuous writing.
I found "use_single_write" in regmap, I will remove "AW88399_DSP_I2C_WRITES".
Best regards, Weidong Wang