Re: [PATCH] ALSA: Use of_property_read_bool() for boolean properties

On Fri, Mar 10, 2023 at 08:47:33AM -0600, Rob Herring wrote:

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring robh@kernel.org

sound/ppc/tumbler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c index 6c882873b344..12f1e10db1c4 100644 --- a/sound/ppc/tumbler.c +++ b/sound/ppc/tumbler.c @@ -1361,7 +1361,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)

for_each_child_of_node(chip->node, np) { if (of_node_name_eq(np, "sound")) {

• 	if (of_get_property(np, "has-anded-reset", NULL))
  

• 	if (of_property_read_bool(np, "has-anded-reset"))
  	mix->anded_reset = 1;
  if (of_property_present(np, "layout-id"))
  	mix->reset_on_sleep = 0;
  

-- 2.39.2