
4 Dec
2014
4 Dec
'14
10 a.m.
On 12/03/14 17:25, Mark Brown wrote:
On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote:
case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
dev->active--;
if (dev->active > 0)
dev->active--;
How is this triggering - this sounds like you're papering over some other bug somewhere?
When I looked at the code paths I couldn't convince myself that STOP wouldn't be called more than once. Then actuve would be negative and the device might not be restartable. I didn't have a problem per se, it was just that it seemed to be something of a loophole.
Andrew