Re: [alsa-devel] [PATCH] ASoC: Intel: add bytcr-wm5102 machine driver

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index dd250b8..1669c46 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -240,10 +240,17 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx) }

-static int is_byt_cr(struct device *dev, bool *bytcr) +static int is_byt_cr(struct device *dev, struct sst_acpi_mach *mach, bool *bytcr) { int status = 0;

• /* Lenovo Yoga2 exception - acpi_ipc_irq_index is the 1st index,

•   but iosf_mbi_read (bios_status) returns 0 for bits 26:27 */
  

• if (!strcmp(mach->drv_name, "bytcr_wm5102")) {

• *bytcr = true;
  

• return status;
  

• }

well no, this isn't the right way to do this. quirks need to be based on real hardware information (e.g. DMI) and not a driver name.

The rest looks more of less ok, it's not clear to me if all the quirks are needed and make sense.