Re: [PATCH] ALSA: drivers: opl3: Fix incorrect use of vp->state

On Sun, 12 Dec 2021 18:20:25 +0100, Colin Ian King wrote:

Static analysis with scan-build has found an assignment to vp2 that is never used. It seems that the check on vp->state > 0 should be actually on vp2->state instead. Fix this.

This dates back to 2002, I found the offending commit from the git history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git, commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")

Signed-off-by: Colin Ian King colin.i.king@gmail.com

Thanks, applied now with Cc-to-stable.

Takashi