23 Jun
2019
23 Jun
'19
11:35 p.m.
On Sat, Jun 22, 2019 at 10:35:23AM +0900, Takashi Sakamoto wrote:
(sound/firewire/amdtp-stream.c) void amdtp_stream_stop(struct amdtp_stream *s) { mutex_lock(&s->mutex);
if (!amdtp_stream_running(s)) { mutex_unlock(&s->mutex); return; } ... fw_iso_context_destroy(s->context); s->context = ERR_PTR(-1);
It might be nice to wrap this assignment in a function call:
void mark_stream_not_running(struct amdtp_stream *s) { s->context = ERR_PTR(-1); }
Or we could leave it as is... It doesn't really matter too much.
regards, dan carpenter