Re: [alsa-devel] [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789

On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote:

On Mon, Mar 05, 2018 at 01:48:16PM +0100, Mylène Josserand wrote:

...

--- /dev/null +++ b/sound/soc/codecs/pcm1789-i2c.c @@ -0,0 +1,76 @@ +// SPDX-License-Identifier: GPL-2.0 +/*

• • PCM1789 ASoC I2C driver
• • Copyright (c) Bootlin 2018
• • Mylène Josserand mylene.josserand@bootlin.com
• • This program is free software; you can redistribute it and/or
• • modify it under the terms of the GNU General Public License

Please don't mix C and C++ style comments in a single comment like this

• it looks unintentional. Just use the same style for the whole thing.

You also don't need to include all the boilerplate with the SPDX header.

I think Linus made it clear that he wants the SPDX header to be a C++ comment, the documentation has:

" 2. Style:

The SPDX license identifier is added in form of a comment. The comment style depends on the file type::

C source: // SPDX-License-Identifier: <SPDX License Expression> "

I agree the boilerplate should be removed.